New Sponsor List organism #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
xentenza
commented
Sep 10, 2024
xentenza
commented
- new organism: "Sponsor List"
- new picture for molecules/sponsors
- new organism: "Sponsor List" - new picture for molecules/sponsors
Test Results 1 files 1 suites 0s ⏱️ For more details on these errors, see this check. Results for commit bb9dffe. ♻️ This comment has been updated with latest results. |
|
🔎 Download the Backstop report for this pull request (link valid for 90 days): |
- added variant with link
- created molecules/sponsor/sponsor-link.twig - updated organisms/sponsor-list-link.twig
make it compatible with the WordPress structure ;-)
missing div
williambelle
approved these changes
Sep 26, 2024
Problems with block alignment when sponsors do not have names of the same length
alinekeller
requested changes
Oct 22, 2024
There was a problem hiding this comment.
Même remarque concernant l'attribut ALT.
There was a problem hiding this comment.
Le contenu de l'attribut ALT devrait reprendre le texte présent sur le logo, pas indiquer "Sponsor". Ici par exemple juste "EPFL".
alinekeller
approved these changes
Oct 30, 2024
williambelle
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.